Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APP-3098 - Refactor IPFS pinning and fetching to use Pinata #1346

Merged
merged 19 commits into from
May 14, 2024
Merged

fix: APP-3098 - Refactor IPFS pinning and fetching to use Pinata #1346

merged 19 commits into from
May 14, 2024

Conversation

sepehr2github
Copy link
Contributor

@sepehr2github sepehr2github commented May 12, 2024 •
edited by jira bot
Loading

Description

  • Added getData function to IPFSService
  • Refactored pinData function to use pinata
  • Removed addData function
  • ReImplemented SDK getDao, getProposals and getProposals function into the app
  • Defined Pinata required env variables

Task: APP-3098

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@sepehr2github sepehr2github changed the title Refactor IPFS pinning based on pinata - Current SDK Version fix: APP-3098 - Refactor IPFS pinning based on pinata - Current SDK Version May 12, 2024
@sepehr2github sepehr2github changed the title fix: APP-3098 - Refactor IPFS pinning based on pinata - Current SDK Version fix: APP-3098 - Refactor IPFS pinning and fetching to use Pinata May 14, 2024
@sepehr2github sepehr2github marked this pull request as ready for review May 14, 2024 10:12
@sepehr2github sepehr2github requested a review from a team May 14, 2024 11:59
@jjavieralv
Copy link
Contributor

Test this link :)
https://aragon-1.mypinata.cloud/ipfs/QmS8mzGjgvybGhvxTsP2WJXpcK9qtd8mFGJUobtYwwRoYZ/

thekidnamedkd
thekidnamedkd approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @sepehr2github. I left a few comments and questions. Not a small ticket buddy. Lot of fresh code here. 😅

thekidnamedkd
thekidnamedkd requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally approved. Temp hold.

@CLAassistant
Copy link

CLAassistant commented May 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

WebApp IPFS Hash: QmaLP7cF4mV58UJtEhMDzqwsUBLmjYoq4nbeKdLbDyRFbd
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/QmaLP7cF4mV58UJtEhMDzqwsUBLmjYoq4nbeKdLbDyRFbd/

thekidnamedkd
thekidnamedkd approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - way to persevere @sepehr2github! Excited for QA @Barukimang :)

@Barukimang Barukimang merged commit c5ce205 into develop May 14, 2024
3 checks passed
@Barukimang Barukimang deleted the fix/app-3098 branch May 14, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekidnamedkd thekidnamedkd thekidnamedkd approved these changes

Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sepehr2github @jjavieralv @CLAassistant @thekidnamedkd @Barukimang @Fabricevladimir